Skip to content

Remove use of deprecated request.is_ajax() #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2020
Merged

Remove use of deprecated request.is_ajax() #1253

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion debug_toolbar/middleware.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import re
from functools import lru_cache

import django
from django.conf import settings
from django.utils.module_loading import import_string

Expand Down Expand Up @@ -48,7 +49,11 @@ def __call__(self, request):
# Decide whether the toolbar is active for this request. Don't render
# the toolbar during AJAX requests.
show_toolbar = get_show_toolbar()
if not show_toolbar(request) or request.is_ajax():
if not show_toolbar(request) or (
request.is_ajax()
if django.VERSION < (3, 1)
else not request.accepts("text/html")
):
return self.get_response(request)

toolbar = DebugToolbar(request, self.get_response)
Expand Down