Eliminate some inline styles #1249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1249 +/- ##
==========================================
+ Coverage 86.61% 86.66% +0.05%
==========================================
Files 25 25
Lines 1449 1447 -2
Branches 205 205
==========================================
- Hits 1255 1254 -1
+ Misses 142 141 -1
Partials 52 52
Continue to review full report at Codecov.
|
jdufresne
reviewed
Mar 29, 2020
Contributor
jdufresne
left a comment
jdufresne
left a comment
There was a problem hiding this comment.
Thanks for this improvement. I think this is a good move.
jdufresne
approved these changes
Mar 31, 2020
xi
force-pushed
the
eliminate-inline-styles
branch
from
09a5e1f to
2ea3553
Compare
Contributor
Author
|
What is the status here? Anything I can do to get this merged? |
Contributor
|
Thanks! Sorry for the delay merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inline styles are used for the following:
(1) is can trivially be replaced with a class. (2) can be replaced with SVG. I did not find solutions for the other two cases.