Skip to content

Remove unnecessary JavaScript function applyStyle() #1220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2019
Merged

Remove unnecessary JavaScript function applyStyle() #1220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions debug_toolbar/static/debug_toolbar/js/toolbar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,20 +312,13 @@
return value;
}
},
applyStyle: function(name) {
var selector = '#djDebug [data-' + name + ']';
document.querySelectorAll(selector).forEach(function(element) {
element.style[name] = element.getAttribute('data-' + name);
});
}
};
window.djdt = {
show_toolbar: djdt.show_toolbar,
hide_toolbar: djdt.hide_toolbar,
init: djdt.init,
close: djdt.hide_one_level,
cookie: djdt.cookie,
applyStyle: djdt.applyStyle
};
document.addEventListener('DOMContentLoaded', djdt.init);
})();
3 changes: 0 additions & 3 deletions debug_toolbar/static/debug_toolbar/js/toolbar.profiling.js
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions debug_toolbar/static/debug_toolbar/js/toolbar.sql.js
View file
Open in desktop

This file was deleted.

4 changes: 1 addition & 3 deletions debug_toolbar/templates/debug_toolbar/panels/profiling.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
{% for call in func_list %}
<tr class="{% cycle 'djDebugOdd' 'djDebugEven' %} djDebugProfileRow{% for parent_id in call.parent_ids %} djToggleDetails_{{ parent_id }}{% endfor %}" depth="{{ call.depth }}" id="profilingMain_{{ call.id }}">
<td>
<div data-padding-left="{{ call.indent }}px">
<div style="padding-left:{{ call.indent }}px">
{% if call.has_subfuncs %}
<a class="djProfileToggleDetails djToggleSwitch" data-toggle-name="profilingMain" data-toggle-id="{{ call.id }}" data-toggle-open="+" data-toggle-close="-" href>-</a>
{% else %}
Expand All @@ -32,5 +32,3 @@
{% endfor %}
</tbody>
</table>

<script src="{% static 'debug_toolbar/js/toolbar.profiling.js' %}" defer></script>
12 changes: 5 additions & 7 deletions debug_toolbar/templates/debug_toolbar/panels/sql.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<ul class="djdt-stats">
{% for alias, info in databases %}
<li>
<strong class="djdt-label"><span data-background-color="rgb({{ info.rgb_color|join:", " }})" class="djdt-color">&#160;</span> {{ alias }}</strong>
<strong class="djdt-label"><span style="background-color:rgb({{ info.rgb_color|join:', ' }})" class="djdt-color">&#160;</span> {{ alias }}</strong>
<span class="djdt-info">{{ info.time_spent|floatformat:"2" }} ms ({% blocktrans count info.num_queries as num %}{{ num }} query{% plural %}{{ num }} queries{% endblocktrans %}
{% if info.similar_count %}
{% blocktrans with count=info.similar_count trimmed %}
Expand Down Expand Up @@ -34,7 +34,7 @@
<tbody>
{% for query in queries %}
<tr class="{% cycle 'djDebugOdd' 'djDebugEven' %}{% if query.is_slow %} djDebugRowWarning{% endif %}{% if query.starts_trans %} djDebugStartTransaction{% endif %}{% if query.ends_trans %} djDebugEndTransaction{% endif %}{% if query.in_trans %} djDebugInTransaction{% endif %}" id="sqlMain_{{ forloop.counter }}">
<td class="djdt-color"><span data-background-color="rgb({{ query.rgb_color|join:", " }})">&#160;</span></td>
<td class="djdt-color"><span style="background-color:rgb({{ query.rgb_color|join:', '}})">&#160;</span></td>
<td class="djdt-toggle">
<a class="djToggleSwitch" data-toggle-name="sqlMain" data-toggle-id="{{ forloop.counter }}" data-toggle-open="+" data-toggle-close="-" href="">+</a>
</td>
Expand All @@ -44,19 +44,19 @@
</div>
{% if query.similar_count %}
<strong>
<span data-background-color="{{ query.similar_color }}">&#160;</span>
<span style="background-color:{{ query.similar_color }}">&#160;</span>
{% blocktrans with count=query.similar_count %}{{ count }} similar queries.{% endblocktrans %}
</strong>
{% endif %}
{% if query.duplicate_count %}
<strong>
<span data-background-color="{{ query.duplicate_color }}">&#160;</span>
<span style="background-color:{{ query.duplicate_color }}">&#160;</span>
{% blocktrans with dupes=query.duplicate_count %}Duplicated {{ dupes }} times.{% endblocktrans %}
</strong>
{% endif %}
</td>
<td class="djdt-timeline">
<div class="djDebugTimeline"><div class="djDebugLineChart{% if query.is_slow %} djDebugLineChartWarning{% endif %}" data-left="{{ query.start_offset|unlocalize }}%"><strong data-width="{{ query.width_ratio_relative|unlocalize }}%" data-background-color="{{ query.trace_color }}">{{ query.width_ratio }}%</strong></div></div>
<div class="djDebugTimeline"><div class="djDebugLineChart{% if query.is_slow %} djDebugLineChartWarning{% endif %}" style="left:{{ query.start_offset|unlocalize }}%"><strong style="width:{{ query.width_ratio_relative|unlocalize }}%;background-color:{{ query.trace_color }}">{{ query.width_ratio }}%</strong></div></div>
</td>
<td class="djdt-time">
{{ query.duration|floatformat:"2" }}
Expand Down Expand Up @@ -113,5 +113,3 @@
{% else %}
<p>{% trans "No SQL queries were recorded during this request." %}</p>
{% endif %}

<script src="{% static 'debug_toolbar/js/toolbar.sql.js' %}" defer></script>
2 changes: 0 additions & 2 deletions debug_toolbar/templates/debug_toolbar/panels/sql_explain.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,3 @@ <h3>{% trans "SQL explained" %}</h3>
</table>
</div>
</div>

<script src="{% static 'debug_toolbar/js/toolbar.sql.js' %}" defer></script>
2 changes: 0 additions & 2 deletions debug_toolbar/templates/debug_toolbar/panels/sql_profile.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,5 +40,3 @@ <h3>{% trans "SQL profiled" %}</h3>
{% endif %}
</div>
</div>

<script src="{% static 'debug_toolbar/js/toolbar.sql.js' %}" defer></script>
2 changes: 0 additions & 2 deletions debug_toolbar/templates/debug_toolbar/panels/sql_select.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,3 @@ <h3>{% trans "SQL selected" %}</h3>
{% endif %}
</div>
</div>

<script src="{% static 'debug_toolbar/js/toolbar.sql.js' %}" defer></script>