Remove jquery #1085
Merged
Remove jquery #1085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
not: not supported in edge https://caniuse.com/#feat=details
This is duplicated functionality. You can already toggle the entries using .djToggleSwitch
AFAIU it is never used because the background-color is always overwritten by applyStyle
this is already handled in the close.djDebug event listener
already done in close.djDebug handler
NOTE: removes custom event
Note: removes animations
Member
|
Awesome! |
Contributor
Author
|
That was quick. Thanks! |
Merged
Contributor
|
The removal of the Had a bit of a hard time tracking down what had happened here. Maybe it's still worth updating? |
matthiask
added a commit
that referenced
this pull request
May 10, 2020
Member
|
@WhyNotHugo Sure! Thanks. I just proposed a documentation change here: #1266 |
auvipy
added a commit
that referenced
this pull request
May 10, 2020
Refs #1085: Mention the removal of JQUERY_URL in the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a full port to vanilla javascript, ditching jquery. Fixes #562.
It uses many modern DOM features such as fetch, classList, or NodeList.forEach. All of them are supported in all major browsers though.
This includes some refactoring which might also fix some bugs (e.g. #605).
I removed the open/close animation. It is probably possible to bring it back, but I did not focus on that yet.