Skip to content

Promote httpx dependency #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2024
Merged

Promote httpx dependency #137

merged 1 commit into from
Mar 26, 2024

Conversation

chriso
Copy link
Contributor

@chriso chriso commented Mar 26, 2024

Same issue as #130. The dispatch.test package relies on httpx to make requests to the endpoint. The package and python -m dispatch.test command don't work if httpx is only a dev dependency.

@chriso chriso merged commit c1d396b into main Mar 26, 2024
@chriso chriso deleted the promote-httpx branch March 26, 2024 01:53
@chriso chriso self-assigned this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@achille-roussel achille-roussel achille-roussel approved these changes

@pelletier pelletier Awaiting requested review from pelletier

@Pryz Pryz Awaiting requested review from Pryz

Assignees

@chriso chriso

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chriso @achille-roussel