Skip to content

types: reverse interface inheritance to omit Omit #10923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Qjuh
Copy link
Member

@Qjuh Qjuh commented Jun 6, 2025

Please describe the changes this PR makes and why it should be merged:

For documentation purposes it is better to have regular inheritance, without Omit<> or Pick<> types in the inheritance chain.
While implementing this change I also fixed some bugs in typings, for example:

  • Interaction#awaitModalSubmit(..) had too many allowed options in typings, that wouldn't do anything
  • ForumChannel#lastMessageId doesn't exist

Status and versioning classification:

@Qjuh Qjuh requested a review from a team as a code owner June 6, 2025 19:30
Copy link

vercel bot commented Jun 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Jun 6, 2025 7:31pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Jun 6, 2025 7:31pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants