Skip to content

Conversation

@onerandomusername
Copy link
Contributor

Group Direct Message channels can have a nullable name, which is exposed to bots via fetching an invite that goes to a group DM.

@Jupith
Copy link
Contributor

Jupith commented Mar 2, 2022

pretty sure they don't document any quirks belonging to group dms since their considered deprecated

@onerandomusername
Copy link
Contributor Author

pretty sure they don't document any quirks belonging to group dms since their considered deprecated

Group DMs are still exposed to bots when fetching an invite that goes to a group dm, which to my knowledge are not deprecated. These invites can be sent in servers, which means that a bot that filters invites by their targets is not expecting a null name for the invite's channel.

@SinisterRectus
Copy link
Contributor

See #1639 for the same rejected change(s) and comment from night.

@onerandomusername
Copy link
Contributor Author

There's numerous code review comments which have not been addressed, and given managed group dms are somewhat deprecated and not really used I don't imagine there's much use to documenting these changes anyhow.

These aren't managed group dms, though. Group DM channels are fetchable by any bot, using a group dm invite.

@night night merged commit bf135de into discord:main Mar 29, 2022
@onerandomusername onerandomusername deleted the patch-1 branch March 29, 2022 18:16
Nihlus added a commit to Remora/Remora.Discord that referenced this pull request Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants