Skip to content

Conversation

@bombycilla
Copy link

Solves the issue in lighthouse #1924.

@kasperg
Copy link

kasperg commented Sep 28, 2012

Thank you for the contribution!

Before we merge this there are a few things I would like to see changed. I've hightligted some below.

In general remember to check whether the new/updated code follows the Drupal Coding Standards as required by the Ding Code Guideline. A growing number of editors and IDE allow integration with the Drupal Code Sniffer which makes checking quite easy.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The referenced ticket provides a more elaborate reasoning behind why this cleanup is necessary. I would like to have this documented in the code comments as well.

If this is a general problem consider submitting this as a patch for the DIBS module instead of implementing it here.

@mikl
Copy link
Member

mikl commented Oct 22, 2012

I'm not sure I see the need for this change. Destroying financial transaction data should not be done lightly.

Even if we want this change in core, I think running it every time cron runs is a bit wasteful. It is a fairly expensive query, and it should be sufficient to run it every 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants