Support for Laravel 4.2

[bweston92]

I just started playing with Laravel 4.2 and got a lot of issues installing this package. I have suggested the following allowing for 4.1.* and 4.2.* installations.

I believe this would work if not let me know of way.

[GrahamCampbell]

Better to use ~4.1.

[bweston92]

@GrahamCampbell is that ok? what is the difference?

[GrahamCampbell]

The difference is that you where saying get any version so long as it is at least 4.1. That means we could be getting verion 6.3 for example. Using ~ means we are getting any 4.x version so long as it is at least 4.1.

[jasonlewis]

Have you checked that the package actually works under 4.2? I haven't looked yet. Hoping nothing has changed in the router.

[bweston92]

It seems to have passed tests ok.

[GrahamCampbell]

@bweston92 That's because the test suite loaded laravel 4.1, not 4.2...

[bweston92]

Hmm want me to pull and do the tests on 4.2?—
Sent from Mailbox for iPhone

On Wed, May 14, 2014 at 10:43 AM, Graham Campbell
[email protected] wrote:

@bweston92 That's because the test suite loaded laravel 4.1, not 4.2...

Reply to this email directly or view it on GitHub:
#44 (comment)

[hipsterjazzbo]

Has anyone been able to confirm this is good? I'd really love it if this could be merged so I can update Laravel to 4.2 beta.

[jasonlewis]

I'll be taking a look in the coming days. :-)
On 16 May 2014 13:29, "Caleb Fidecaro" [email protected] wrote:

Has anyone been able to confirm this is good? I'd really love it if this
could be merged so I can update Laravel to 4.2 beta.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/44#issuecomment-43294210
.

[hipsterjazzbo]

Fantastic! I'm chomping at the bit to use the new global scopes in 4.2 :) Excellent package BTW. Love it.

[Anahkiasen]

👍 For this, I'm using this fork on my project for now but it's such a lightweight pull I hope it gets merged soon.

[hipsterjazzbo]

I'm doing the same. Seems to work okay.

On Fri, May 23, 2014 at 12:19 AM, Maxime Fabre [email protected]
wrote:

👍 For this, I'm using this fork on my project for now but it's such an easy pull I hope it gets merged soon.

Reply to this email directly or view it on GitHub:
#44 (comment)

[jasonlewis]

Going to merge this in and hopefully anything that's going to pop up will show itself before this package stabilizes.