Input::file not being parsed

[jacobwindsor]

The Input::file functions are not being parsed and always return as null values. The functions work as expected when outside of the Dingo API route but always return as null when inside it.

[jasonlewis]

I'll take a look at this on the weekend (if I'm not working over time). 😁

[andymrussell]

+1

[jasonlewis]

This is working fine for me when testing with cURL.

$ curl -F "example=@/path/to/file" http://api.dev/upload

Route::post('upload', function()
{
    dd(Input::file('example'));
});

This API route dumps out the uploaded file correctly.

[andymrussell]

It doesn't seem to work with internal API requests.

[jasonlewis]

Aye, I did notice that. Should be a simple fix. Just wanted to confirm that
it wasn't with regular requests to the API.
On 27 Jun 2014 18:39, "andymrussell" notifications@github.com wrote:

It doesn't seem to work with internal API requests.

—
Reply to this email directly or view it on GitHub
#58 (comment).

[jasonlewis]

Just wanting to clarify... Are you actually using internal requests to send a file? If so, how?

[andymrussell]

Here is a rough example:

$user = User::find(1);
$path = base_path().'/app/tests/api/v1/';
$filename = 'fileupload.txt';
$mimeType = 'text/plain';
// Create the test upload file
File::put($path.$filename, 'file contents');
$file = new Symfony\Component\HttpFoundation\File\UploadedFile($path . $filename, $filename, $mimeType);
$response = API::be($user)->with([
    'name'         => $faker->name,
    'media'         => $file,
    ])->route('something.create');

[jasonlewis]

Hm, yeah, not very elegant. Going to add an attach method I think.
On 1 Jul 2014 00:35, "andymrussell" notifications@github.com wrote:

Here is a rough example:

$user = User::find(1);

$path = base_path().'/app/tests/api/v1/';
$filename = 'fileupload.txt';
$mimeType = 'text/plain';

// Create the test upload file
File::put($path.$filename, 'file contents');

$file = new Symfony\Component\HttpFoundation\File\UploadedFile($path . $filename, $filename, $mimeType);

$response = API::be($user)->with([
'name' => $faker->name,
'media' => $file,
])->route('something.create');

—
Reply to this email directly or view it on GitHub
#58 (comment).

[jasonlewis]

I've just pushed an attach method to master. I'm not tagging anything yet. If you've got time give it a shot, you just pass an array of file names and paths.

API::attach(['file' => 'path/to/file'])->post('upload');

[andymrussell]

It seems when creating an instance of UploadedFile, you need to define a mime type, and file size, etc.
If blank it default to "application/octet-stream", so validating mime types fail.
There also doesn't appear to be a file size by default, so this also fails validation.

What do you think about being able to pass in the Input::file('media') through the API class rather than the actual path/to/file?
or maybe pass in either?

i.e.

API::attach([
    'file1' => Input::file('media'),
    'file2' => [
            'file' => 'path/to/file',
            'mimeType' => 'text/plain',
            'fileSize' => 1024
        ]
    ])->post('upload');

The use case would be:
Front end posts file to a controller which then make the internal API request to perform processing (validation, storage, upload to S3, etc).

So something like:

    /**
     * Attach files to be uploaded.
     * 
     * @param  array  $files
     * @return \Dingo\Api\Dispatcher
     */
    public function attach(array $files)
    {
        foreach ($files as $key => $file) {
            if($file instanceof UploadedFile)
            {
                $this->files[$key] = $file;
            }
            elseif(isset($file['file']))
            {
                $this->files[$key] = new UploadedFile(
                    $file['file'],
                    basename($file['file']),
                    (isset($file['mimeType']) ? $file['mimeType'] : null), // This should be automated?
                    (isset($file['fileSize']) ? $file['fileSize'] : null), // This should be automated?
                );
            }
        }
        return $this;
    }

[jasonlewis]

Will look into it when I can mate. Cheers. 😄

[hskrasek]

I believe as of commit f606903, this issue is now resolved.

[jasonlewis]

I've now tweaked this quite a bit. You can pass an instance of UploadedFile directly in, a simple path, or an array with the following keys: path, mime, size.

Also a plain path will have its mime and size detected. It's obviously better to supply this yourself though.

[andymrussell]

Awesome! Good man! :-)