Skip to content

Conversation

@dimonovp
Copy link
Owner

Original Pull Request

magento#13816

Description

Without the @api annotation implementing this interface would require a patch level dependency on magento/framework.
This PR changes that by adding an @api annotation so that only a minor version dependency is required according to http://devdocs.magento.com/guides/v2.2/extension-dev-guide/versioning/dependencies.html

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable) NA
  • All automated tests passed successfully (all builds on Travis CI are green) NA

svitja and others added 23 commits March 14, 2018 10:38
[TSG] Forwardports for 2.3 (pr5) (2.3.0)
@dimonovp dimonovp closed this Mar 19, 2018
@dimonovp dimonovp deleted the 2.3-develop-PR-port-13816 branch March 19, 2018 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants