Fixes for pytest 8.4 #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the codebase to be compatible with pytest 8.4 by replacing deprecated internal APIs with standard library equivalents. The main changes involve switching from pytest's internal _api.is_generator function to Python's built-in inspect.isgeneratorfunction and updating fixture wrapping mechanisms.
- Replace deprecated
_api.is_generatorwithinspect.isgeneratorfunction - Update fixture wrapping by using
__signature__ = Noneinstead of deleting__wrapped__ - Remove imports of deprecated pytest internal APIs (
is_generator,_PytestWrapper)
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/test_fixtures.py | Updates test to use isgeneratorfunction and removes _api import |
| src/unmagic/fixtures.py | Replaces _api.is_generator calls and updates fixture wrapping mechanism |
| src/unmagic/autouse.py | Adds isgeneratorfunction import and replaces _api.is_generator usage |
| src/unmagic/_api.py | Removes imports of deprecated pytest internal APIs |
gherceg
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3
🐡 Review by commit.