Handle int64 as string with format #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
context: - grpc-ecosystem/grpc-gateway#438 - golang/protobuf#1414 - https://github.com/OpenAPITools/openapi-generator-cli Originally, this was changed so that int64 fields would be written to the openapi spec as integer types which is supported by the OpenAPI spec. However, jsonpb and other related projects have chosen to enforce that int64 fields are written as strings. This is because JavaScript represents integers as 32 bit numbers and if you pass it a value that is outside of that range it will overflow. Since we are using jsonpb to transform the protos to json, we need to make sure that the generated schema is consistent with the jsonpb behavior.
ajorgensen
force-pushed
the
aj/handle-int64
branch
2 times, most recently
from
3d72650 to
2e9f9d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context:
Originally, this was changed so that int64 fields would be written to
the openapi spec as integer types which is supported by the OpenAPI
spec. However, jsonpb and other related projects have chosen to enforce
that int64 fields are written as strings. This is because JavaScript
represents integers as 32 bit numbers and if you pass it a value that is
outside of that range it will overflow. Since we are using jsonpb to
transform the protos to json, we need to make sure that the generated
schema is consistent with the jsonpb behavior.