Skip to content

Fix nil pointer exception in handleIssueCommentEvent when GitHub App … #2192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
+15 −1
Open

Fix nil pointer exception in handleIssueCommentEvent when GitHub App … #2192

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3404f75
Fix nil pointer exception in handleIssueCommentEvent when GitHub App …
MrKeiKun Sep 20, 2025
6df6953
Fix variable redeclaration errors by changing := to = for existing va…
MrKeiKun Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion backend/controllers/github_comment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,18 @@ func handleIssueCommentEvent(gh utils.GithubClientProvider, payload *github.Issu
repoFullName := *payload.Repo.FullName
cloneURL := *payload.Repo.CloneURL
issueNumber := *payload.Issue.Number

if payload.Installation == nil {
slog.Error("Installation is nil in payload", "issueNumber", issueNumber)
return fmt.Errorf("installation is missing from payload")
}

installationId = *payload.Installation.ID
repoName = *payload.Repo.Name
repoOwner = *payload.Repo.Owner.Login
repoFullName = *payload.Repo.FullName
cloneURL = *payload.Repo.CloneURL
issueNumber = *payload.Issue.Number
isDraft := payload.Issue.GetDraft()
userCommentId := *payload.GetComment().ID
actor := *payload.Sender.Login
Expand Down Expand Up @@ -81,8 +93,9 @@ func handleIssueCommentEvent(gh utils.GithubClientProvider, payload *github.Issu
if link == nil {
slog.Error("GitHub app installation link not found",
"installationId", installationId,
"issueNumber", issueNumber,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Good addition of issueNumber field to maintain consistency with logging patterns elsewhere in the codebase
Context Used: Context - Enrich debug logs with relevant context. Always include identifiers like 'prNumber' in logs to facilitate easier tracing and troubleshooting. (link)

)
return fmt.Errorf("github app installation link not found")
return fmt.Errorf("GitHub App installation not found for installation ID %d. Please ensure the GitHub App is properly installed on the repository and the installation process completed successfully", installationId)
}
orgId := link.OrganisationId

Expand All @@ -108,6 +121,7 @@ func handleIssueCommentEvent(gh utils.GithubClientProvider, payload *github.Issu
slog.Error("Error getting GitHub service",
"installationId", installationId,
"repoFullName", repoFullName,
"issueNumber", issueNumber,
"error", ghServiceErr,
)
return fmt.Errorf("error getting ghService to post error comment")
Expand Down
Loading