Minor tweaks to homepage READMEs #1534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CI in particular).
|
Probably easier to review from this link: https://github.com/diffplug/spotless/tree/feat/homepage |
|
LGTM! And I can see why you've removed the link to Gitter, given it's been suffering from a slow death for a long time. So I'm happy with all these changes. The monoculture thing is indeed a problem, but it's not clear to me how much of a problem it will be for the project in the long run, given that SaaS offerings - even self-hosted ones - come and go, and bit rot is a thing anyway. So I'm happy no matter which direction you decide to go with GitHub Discussions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a few small changes
I think we might be better off turning on GitHub Discussions. I said no to that earlier to avoid monoculture, but we're on GitHub Actions now, and the ability to morph discussions smoothly into issues is pretty neat. Especially if we don't have to explicitly advertise it since it's just built into the UI.