Add gzip compression #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I only merged this to test it because actions didn't seem to let me pull from this branch - we can discuss |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context of being a 6x difference between the compressed and uncompressed CSS and JS
This is causing something like 80% of the load time according to chrome lighthouse
I think this is a regression perhaps app engine did this automatically
http://nginx.org/en/docs/http/ngx_http_gzip_module.html
https://stackoverflow.com/questions/54314250/gzip-in-gke-with-nginx-ingress
nginx/kubernetes-ingress#179
Context that we were already doing this in webpack so just had to "turn it on" in helm/k8s/ingress etc