SMV typechecker cleanup #902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
force-pushed
the
smt-typecheck-cleanup
branch
4 times, most recently
from
dee8b11 to
f7bd2e3
Compare
tautschnig
approved these changes
Dec 26, 2024
|
|
||
| bool is_bool() const | ||
| { | ||
| return from == 0 && to == 1; |
There was a problem hiding this comment.
While I understand that this is the same behaviour as before: why would from == 1 or to == 0 not be permitted?
There was a problem hiding this comment.
See #903, and will add a precondition to the class.
1. smv_ranget is moved into a header file 2. Use override instead of virtual for the methods in smv_typecheckt. 3. Remove unnecessary declarators on method parameters. 4. Use ranged for instead of Forall_operands and forall_operands.
This replaces instances of "throw 0;" by "throw errort()".
This replaces the string literal by an ID.
This renames typecheck(exprt, ...) to typecheck_expr_rec to signal the recursion.
kroening
force-pushed
the
smt-typecheck-cleanup
branch
from
f7bd2e3 to
836a55e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
smv_rangetis moved into a header fileUse
overrideinstead ofvirtualfor the methods insmv_typecheckt.Remove unnecessary declarators on method parameters.
Use ranged
forinstead ofForall_operandsandforall_operands.