Skip to content

Fix fragment of SVA supported by word-level BMC #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 22, 2024
Merged

Fix fragment of SVA supported by word-level BMC #687

merged 2 commits into from
Sep 22, 2024

Conversation

kroening
Copy link
Member

No description provided.

@kroening kroening force-pushed the bmc-supported-SVA branch 4 times, most recently from ac6d13f to 8308349 Compare September 14, 2024 21:11
@kroening kroening marked this pull request as ready for review September 14, 2024 21:13
@kroening kroening force-pushed the bmc-supported-SVA branch 4 times, most recently from 3ae289d to bbceb3a Compare September 17, 2024 14:07
tautschnig
tautschnig approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that there is just one commit left in this PR I am wondering whether there should be test just for what this final commit changes?

@kroening
BMC: deduplicate property encoding
2c25ba1 
This removes the duplicated code for encoding temporal operators for
word-level BMC from wl_instantiatet.
@kroening kroening force-pushed the bmc-supported-SVA branch 2 times, most recently from a40a1bf to c0bb9f4 Compare September 22, 2024 00:05
@kroening
Copy link
Member Author

Now that there is just one commit left in this PR I am wondering whether there should be test just for what this final commit changes?

Test added!

@kroening
Fix fragment of SVA supported by word-level BMC
0675677 
1) The simplifier is changed to stay within SVA when simplifying SVA.

2) The logic that recognises supported SVA is adjusted.
@kroening kroening merged commit 0299e1d into main Sep 22, 2024
7 checks passed
@kroening kroening deleted the bmc-supported-SVA branch September 22, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tautschnig tautschnig tautschnig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kroening @tautschnig