Skip to content

Iss 131 ready #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 3, 2020
Merged

Iss 131 ready #343

merged 5 commits into from
Jun 3, 2020

Conversation

tjj2017
Copy link
Collaborator

@tjj2017 tjj2017 commented May 19, 2020

This PR supersedes PR #342
It fixes Issue 131 and introduces a new model for attribute_size.

@tjj2017 tjj2017 mentioned this pull request May 19, 2020
Copy link
Collaborator

@martin-cs martin-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I appreciate that this is a difficult issue.

@martin-cs
Copy link
Collaborator

Needs an actual rebase as the results of iss_131_vanilla don't match due to other things merged into master.

tjj2017 added 5 commits June 2, 2020 11:14
A new parent package ASVAT and a child package ASVAT.Size_Model have
been introduced to implement the new attribute_size model.
The improved handling of attribute_size removes many error reports.
There are substantial line number differences.
There are differences in reported restriction violations.
I don't know the reason for this.  It may be that suppressing the
front-end "size to small" error, further units are being compiled.
@martin-cs martin-cs merged commit 2dac8ee into diffblue:master Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants