Skip to content

goto-analyzer: support typecasts as left-hand sides #8659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

tautschnig
Copy link
Collaborator

This arises with aarch64 va_list structs (but possibly also in other cases).

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link

codecov bot commented Jun 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.36%. Comparing base (0bb2d02) to head (29421f3).
Report is 12 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8659   +/-   ##
========================================
  Coverage    80.36%   80.36%           
========================================
  Files         1686     1686           
  Lines       206984   206989    +5     
  Branches        73       73           
========================================
+ Hits        166333   166338    +5     
  Misses       40651    40651           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This arises with aarch64 va_list structs (but possibly also in other
cases).
@tautschnig tautschnig force-pushed the goto-analyzer-typecast branch from cdb527d to 29421f3 Compare June 20, 2025 21:31
Copy link
Collaborator

@martin-cs martin-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this fixes the issue. I'm not 100% sure that it won't cause type mismatches when working down the write stack but I think these will hopefully be caught in the eval code.

@tautschnig tautschnig merged commit 4e21449 into diffblue:develop Jun 24, 2025
40 checks passed
@tautschnig tautschnig deleted the goto-analyzer-typecast branch June 24, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants