Skip to content

Add aarch64 (Arm 64-bit) CI job #8572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 25, 2025
Merged

Conversation

tautschnig
Copy link
Collaborator

@tautschnig tautschnig commented Jan 20, 2025

Run regression tests and build release package using GitHub's newly (publicly) available aarch64 runner.

Please review commit-by-commit.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 64.17910% with 24 lines in your changes missing coverage. Please review.

Project coverage is 80.38%. Comparing base (7a6e2f7) to head (431f460).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
src/ansi-c/c_typecheck_expr.cpp 47.05% 9 Missing ⚠️
src/cpp/cpp_internal_additions.cpp 27.27% 8 Missing ⚠️
src/ansi-c/goto-conversion/builtin_functions.cpp 80.00% 4 Missing ⚠️
src/goto-symex/symex_builtin_functions.cpp 62.50% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8572      +/-   ##
===========================================
- Coverage    80.39%   80.38%   -0.01%     
===========================================
  Files         1688     1688              
  Lines       207134   207183      +49     
  Branches        73       73              
===========================================
+ Hits        166520   166549      +29     
- Misses       40614    40634      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

We occasionally see timeouts on GitHub runners for macos-14.
GCC on Arm-only supports additional vector types that compile to
hardware-supported types.
The original tests fail on aarch64 as they has unsigned char. Explicitly
use signed char in this test and create a test for unsigned char that is
marked as failing with the SMT back-ends.
aarch64 ABI (section 7.1.4) mandates that va_list is a struct with
particular members. The C library model was fixed in diffblue#8366, but we
didn't yet implement the struct type support in goto conversion.
Run regression tests and build release package using GitHub's newly
(publicly) available aarch64 runner.
@tautschnig tautschnig merged commit 5cd085b into diffblue:develop Jun 25, 2025
39 of 41 checks passed
@tautschnig tautschnig deleted the arm-ci branch June 25, 2025 08:42
tautschnig added a commit to tautschnig/cbmc that referenced this pull request Jun 25, 2025
This release adds aarch64 va_list support (via diffblue#8572), which makes all
tests pass on aarch64 Linux. We reworked expression simplification
during symbolic execution (via diffblue#8642, diffblue#8647, diffblue#8627) to produce smaller
and quicker-to-solve formulae for scenarios seen by our users.
@tautschnig tautschnig mentioned this pull request Jun 25, 2025
4 tasks
tautschnig added a commit to tautschnig/cbmc that referenced this pull request Jun 25, 2025
This release adds aarch64 va_list support (via diffblue#8572), which makes all
tests pass on aarch64 Linux. We reworked expression simplification
during symbolic execution (via diffblue#8642, diffblue#8647, diffblue#8627) to produce smaller
and quicker-to-solve formulae for scenarios seen by our users.
tautschnig added a commit to tautschnig/cbmc that referenced this pull request Jun 25, 2025
This release adds aarch64 va_list support (via diffblue#8572), which makes all
tests pass on aarch64 Linux. We reworked expression simplification
during symbolic execution (via diffblue#8642, diffblue#8647, diffblue#8627) to produce smaller
and quicker-to-solve formulae for scenarios seen by our users.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants