Skip to content

Move __CPROVER_uninterpreted_* conversion to C type checker #8280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tautschnig
Copy link
Collaborator

We already had type checking of mathematical_function types to support lambda expressions. Special-case symbols with name __CPROVER_uninterpreted_* will now also produce these types. GOTO conversion will no longer give specific treatment to function calls with symbol name __CPROVER_uninterpreted_*.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link

codecov bot commented May 9, 2024

Codecov Report

❌ Patch coverage is 88.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.39%. Comparing base (2e6200a) to head (d42256d).

Files with missing lines Patch % Lines
src/ansi-c/c_typecheck_expr.cpp 70.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8280      +/-   ##
===========================================
- Coverage    80.39%   80.39%   -0.01%     
===========================================
  Files         1688     1688              
  Lines       207403   207399       -4     
  Branches        73       73              
===========================================
- Hits        166749   166745       -4     
  Misses       40654    40654              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tautschnig tautschnig force-pushed the bugfixes/uif-in-quantifier branch from 790e44f to 2c13d82 Compare May 10, 2024 12:56
@remi-delmas-3000
Copy link
Collaborator

We already had type checking of mathematical_function types to support lambda expressions. Special-case symbols with name _CPROVER_uninterpreted* will now also produce these types.

What does this mean in practice ? What does it enable for the user ?

@tautschnig tautschnig force-pushed the bugfixes/uif-in-quantifier branch from 2c13d82 to 116c66d Compare June 12, 2024 15:08
We already had type checking of mathematical_function types to support
lambda expressions. Special-case symbols with name
`__CPROVER_uninterpreted_*` will now also produce these types. GOTO
conversion will no longer give specific treatment to function calls with
symbol name `__CPROVER_uninterpreted_*`.
@tautschnig tautschnig force-pushed the bugfixes/uif-in-quantifier branch from 116c66d to d42256d Compare July 28, 2025 11:35
@tautschnig tautschnig self-assigned this Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants