MMIO instrumentation cleanup #8175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
peterschrammel,
martin-cs,
kroening,
jimgrundy and
TGWDB
as code owners
tautschnig
force-pushed
the
cleanup/mm_io-sequence
branch
2 times, most recently
from
3a4abd8 to
7192b0c
Compare
peterschrammel
approved these changes
Feb 1, 2024
tautschnig
force-pushed
the
cleanup/mm_io-sequence
branch
from
7192b0c to
8f51979
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #8175 +/- ##
========================================
Coverage 79.69% 79.69%
========================================
Files 1680 1680
Lines 195242 195253 +11
========================================
+ Hits 155604 155614 +10
- Misses 39638 39639 +1 ☔ View full report in Codecov by Sentry. |
Use a class to maintain data that remains constant across calls.
Previously, there was no indication as to whether any transformation had taken place.
__CPROVER_mm_io_{r,w} functions are unused until rewrites via mm_io are
done, which is only done when processing the input program by CBMC.
remove_unused_functions would spuriously remove the implementation of
these function, even when they may be needed. Therefore, run mm_io
instrumentation before removing unused functions.
tautschnig
force-pushed
the
cleanup/mm_io-sequence
branch
from
8f51979 to
7ee921b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code cleanup, status output, and a fix of the interaction between mm_io and remove_unused_functions. See individual commit messages for details.