Skip to content

Reduce Thomas and Fotis code ownership #8162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

thomasspriggs
Copy link
Contributor

@thomasspriggs thomasspriggs commented Jan 17, 2024

This PR removes my code ownership except for that of the incremental SMT2 decision procedure. I am expecting the time I can make available for code reviews to be rather limited in the immediate future. As I do not wish to hold up anyone else's work waiting for my review, I am reducing the number of areas for which I am codeowner. I intend to retain code ownership of the incremental SMT2 decision procedure as I have particular expertise in this area.

Included in this PR is a similar change for Fotis.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

I am expecting the time I can make available for code reviews to be
rather limited in the immediate future. As I do not wish to hold up
anyone elses work waiting for my review, I am reducing the number of
areas for which I am codeowner. I intend to retain code ownership of the
incremental SMT decision procedure as I have particular expertise in
this area.
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (caf9768) 79.69% compared to head (faca8e2) 79.69%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8162   +/-   ##
========================================
  Coverage    79.69%   79.69%           
========================================
  Files         1680     1680           
  Lines       195104   195104           
========================================
  Hits        155479   155479           
  Misses       39625    39625           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@martin-cs martin-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all of your hard work.

With my tenure at Diffblue coming to an end, and a vision of myself
working in different domains going forward, I don't think there's
going to be much time to spare working on CBMC on the side. To that
end, I believe it's fair to the project to remove myself from the
`CODEOWNERS` file so that nothing is pending my approval in the future.

It has been an honour and a pleasure working on the project, and
I'm happy with what we've achieved these years.
@thomasspriggs thomasspriggs changed the title Remove Thomas Spriggs code ownership except for incremental SMT2 Reduce Thomas and Fotis code ownership Jan 18, 2024
@thomasspriggs thomasspriggs marked this pull request as ready for review January 18, 2024 12:32
@thomasspriggs thomasspriggs merged commit 519a12b into diffblue:develop Jan 18, 2024
@thomasspriggs thomasspriggs deleted the tas/remove_code_ownership branch January 18, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants