Skip to content

Multiplication encoding: cleanup, Dadda, data #7984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 29, 2023

Conversation

tautschnig
Copy link
Collaborator

Please review commit by commit: This PR does not change the encoding at all, but cleans up the multiplier code to have less defined-out code, fixes a TODO in Wallace tree reduction and adds data for Wallace trees, and finally adds a by-default-disabled implementation of Dadda's multiplier.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

De-duplicate code paths to reduce the amount of code that is defined-out
for the Wallace Tree reduction.
Uses the optimised full-adder encoding when the #define is set (which is
the case by default). Comments now detail the performance variability.
Implement Luigi Dadda (1965)'s reduction scheme, which uses fewer full
adders than Wallace Trees. Still, performance is not strictly better
than without a tree reduction scheme.
@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

Attention: 61 lines in your changes are missing coverage. Please review.

Comparison is base (25cb64d) 78.75% compared to head (1699176) 78.97%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7984      +/-   ##
===========================================
+ Coverage    78.75%   78.97%   +0.21%     
===========================================
  Files         1701     1701              
  Lines       196325   196386      +61     
===========================================
+ Hits        154625   155105     +480     
+ Misses       41700    41281     -419     
Files Coverage Δ
src/solvers/flattening/bv_utils.h 86.66% <ø> (ø)
src/solvers/flattening/bv_utils.cpp 72.90% <16.43%> (-7.39%) ⬇️

... and 37 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tautschnig tautschnig merged commit 7f4570b into diffblue:develop Oct 29, 2023
@tautschnig tautschnig deleted the features/tree-multipliers branch October 29, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants