Skip to content

std::sort requires strict weak ordering #7956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

tautschnig
Copy link
Collaborator

Two of our uses of std::sort failed to satisfy the "strict" part of "strict weak ordering." This resulted in iterators running out of bounds with LLVM's libc++.

Fixes: #7949

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Two of our uses of `std::sort` failed to satisfy the "strict" part of
"strict weak ordering." This resulted in iterators running out of bounds
with LLVM's libc++.

Fixes: diffblue#7949
@tautschnig tautschnig merged commit a531056 into diffblue:develop Oct 12, 2023
@tautschnig tautschnig deleted the bugfixes/7949-comparison branch October 12, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression test failure: goto-analyzer fails with a segmentation fault in MacOS in std::sort of std::vector<constant_interval_exprt>
6 participants