Enable typechecking of shadow memory primitives #7909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esteffin
requested review from
kroening,
tautschnig,
peterschrammel and
remi-delmas-3000
as code owners
esteffin
force-pushed
the
esteffin/define-shadow-memory-primitives
branch
3 times, most recently
from
ce7b861 to
4f49ea5
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #7909 +/- ##
===========================================
+ Coverage 78.91% 78.94% +0.03%
===========================================
Files 1697 1699 +2
Lines 195418 195804 +386
===========================================
+ Hits 154211 154578 +367
- Misses 41207 41226 +19
☔ View full report in Codecov by Sentry. |
| assert(__CPROVER_get_field(&s.j, "uninitialized") == 1); | ||
|
|
||
| return 0; | ||
| } |
There was a problem hiding this comment.
newline at the end (several occurrences)
esteffin
force-pushed
the
esteffin/define-shadow-memory-primitives
branch
3 times, most recently
from
63334e8 to
266114e
Compare
peterschrammel
approved these changes
Sep 27, 2023
esteffin
force-pushed
the
esteffin/define-shadow-memory-primitives
branch
from
266114e to
31577ab
Compare
Adding typecheck code for shadow memory builtins so they are type-checked (more thoroughly than with the C typechecker) and correctly converted to function calls.
Fixed SM failing regression tests due to better error messaging on typecheck.
esteffin
force-pushed
the
esteffin/define-shadow-memory-primitives
branch
from
31577ab to
b7ebd34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables typechecking of shadow memory primitives.
The primitives are checked for correct number of arguments, correct types and also enforce other invariants such as having a constant string for name, a bit-vector type of size
< 8and non-voidpointers for accessing it.It also adds regressions and unit tests for it.