Skip to content

Minor documentation improvements for incremental SMT2 #7890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/solvers/smt2_incremental/object_tracking.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
struct decision_procedure_objectt
{
/// The expression for the root of the object. This is expression equivalent
/// to deferencing a pointer to this object with a zero offset.
/// to dereferencing a pointer to this object with a zero offset.
exprt base_expression;
/// Number which uniquely identifies this particular object.
std::size_t unique_id = 0;
Expand All @@ -57,7 +57,7 @@ struct decision_procedure_objectt
/// assigned.
exprt find_object_base_expression(const address_of_exprt &address_of);

/// Arbitary expressions passed to the decision procedure may have multiple
/// Arbitrary expressions passed to the decision procedure may have multiple
/// address of operations as its sub expressions. This means the overall
/// expression may contain multiple base objects which need to be assigned
/// unique identifiers.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ static smt_responset get_response_to_command(
return response;
}

/// Returns a message string describing the problem in the case where the
/// response from the solver is an error status. Returns empty otherwise.
static optionalt<std::string>
get_problem_messages(const smt_responset &response)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,9 @@ class smt2_incremental_decision_proceduret final
/// \brief Defines any functions which \p expr depends on, which have not yet
/// been defined, along with their dependencies in turn.
void define_dependent_functions(const exprt &expr);
/// If a function has not been defined for handling \p expr, then a new
/// function is defined. If the corresponding function exists already, then
/// no action is taken.
void ensure_handle_for_expr_defined(const exprt &expr);
/// \brief Add objects in \p expr to object_map if needed and convert to smt.
/// \note This function is non-const because it mutates the object_map.
Expand Down