Skip to content

Remove avoidable use of winbug test exclusion #7849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

tautschnig
Copy link
Collaborator

@tautschnig tautschnig commented Aug 14, 2023

Please review commit-by-commit: these tests actually pass on Windows, or making them pass just requires fixing the test pattern file.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.11% ⚠️

Comparison is base (8497305) 78.82% compared to head (c9afc1e) 78.72%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7849      +/-   ##
===========================================
- Coverage    78.82%   78.72%   -0.11%     
===========================================
  Files         1699     1699              
  Lines       195105   195105              
===========================================
- Hits        153799   153600     -199     
- Misses       41306    41505     +199     

see 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

These tests no longer seem to fail in our Windows CI jobs.
Our use of test.pl requires single quotes for tests to the same way
across all platforms.
@tautschnig tautschnig changed the title Experiment: review winbug Remove avoidable use of winbug test exclusion Aug 15, 2023
@tautschnig tautschnig removed their assignment Aug 15, 2023
@tautschnig tautschnig marked this pull request as ready for review August 15, 2023 09:38
Copy link
Contributor

@NlightNFotis NlightNFotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Slight preference over not removing the mechanism, just in case we need to mark any future tests winbug, but I guess that can be looked up in PRs and re-introduced if needed.

@NlightNFotis
Copy link
Contributor

Ignore my previous message - I see that the branch hasn't totally removed the winbug mechanism from the repository. Happy for this to go in, with no reservations from my end.

@tautschnig tautschnig merged commit fa1d719 into diffblue:develop Aug 15, 2023
@tautschnig tautschnig deleted the cleanup/winbug branch August 15, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants