Skip to content

[CI] Fix slack notification for homebrew PR release job #7281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

NlightNFotis
Copy link
Contributor

Remove golang install step (as a go toolchain is already installed in the action runner) and add missing environment variable (SLACK_MESSAGE) to slack notification step for homebrew PR job.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@NlightNFotis NlightNFotis requested a review from a team as a code owner October 27, 2022 21:39
@NlightNFotis NlightNFotis merged commit bb66f51 into diffblue:develop Oct 28, 2022
@NlightNFotis NlightNFotis deleted the fix_homebrew_pr_notif branch October 28, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants