Skip to content

SMT2 back-end: make declare-datatypes standards compatible #7145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tautschnig
Copy link
Collaborator

The standards-compatible syntax is understood by both Z3 (which also accepted the previous one) as well as CVC5 (which only accepts the new one).

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

The standards-compatible syntax is understood by both Z3 (which also
accepted the previous one) as well as CVC5 (which only accepts the new
one).
@kroening
Copy link
Member

Do you happen to know which version of Z3 added support for the new one?
We should communicate a set of supported solver versions.

@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Merging #7145 (5bbb238) into develop (3034749) will not change coverage.
The diff coverage is 33.33%.

@@           Coverage Diff            @@
##           develop    #7145   +/-   ##
========================================
  Coverage    77.87%   77.87%           
========================================
  Files         1576     1576           
  Lines       181824   181824           
========================================
  Hits        141598   141598           
  Misses       40226    40226           
Impacted Files Coverage Δ
src/solvers/smt2/smt2_conv.cpp 68.69% <33.33%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tautschnig
Copy link
Collaborator Author

Do you happen to know which version of Z3 added support for the new one? We should communicate a set of supported solver versions.

I have only tested with version 4.8.7 (has been released 2019-11-19) on my system, I wasn't aware that support for this varied over time.

Copy link
Collaborator

@martin-cs martin-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful; thank you.

@martin-cs
Copy link
Collaborator

Do you happen to know which version of Z3 added support for the new one? We should communicate a set of supported solver versions.

I have only tested with version 4.8.7 (has been released 2019-11-19) on my system, I wasn't aware that support for this varied over time.

Datatypes were only added to the standard SMT-LIB in 2.6, so July 2017. They were supported by a number of solvers long before that but with varying syntax.

@martin-cs
Copy link
Collaborator

This fails the coverage test but I think that is more due to limitations of our testing of the SMT-LIB back-end than anything to do with this patch so I am merging it.

@martin-cs martin-cs merged commit 22cd6d1 into diffblue:develop Sep 29, 2022
@tautschnig tautschnig deleted the bugfixes/smt2-declare-datatypes branch September 29, 2022 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants