writeable_object and live_object #7125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kroening
commented
Sep 12, 2022
kroening
commented
- Each commit message has a non-empty body, explaining why the change was made.
- n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
- Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- n/a My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.
This adds three predicates to the C frontend, for the benefit of the CHC encoder. They indicate 1) doubly-linked dynamically allocated null-terminated lists, 2) doubly-linked dynamically allocated cyclic lists, and 3) doubly-linked lists with dynamically allocated inner nodes and head and tail sentinel nodes.
This adds C syntax for writeable_object_exprt and live_object_exprt.
Codecov Report
@@ Coverage Diff @@
## develop #7125 +/- ##
===========================================
- Coverage 77.91% 77.86% -0.05%
===========================================
Files 1576 1576
Lines 181662 181779 +117
===========================================
+ Hits 141542 141551 +9
- Misses 40120 40228 +108
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
tautschnig
reviewed
Sep 12, 2022
|
|
||
| return live_object_expr; | ||
| } | ||
| else if(identifier == CPROVER_PREFIX "WRITEABLE_OBJECT") |
There was a problem hiding this comment.
I'm starting to wonder: to what extent is this different from __CPROVER_w_ok(p, 1)?
There was a problem hiding this comment.
Very. The idea is to define w_ok(p, s) = writeable ∧ live ∧ offset+s≤object_size.
This won't work in CBMC without major changes, so this will be CHC only for now.
tautschnig
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.