Skip to content

Avoid short-lived heap-allocated objects #6055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

tautschnig
Copy link
Collaborator

valgrind --tool=dhat reports these as heap allocations that only have a
lifetime of a few hundred instructions, or even less than 100.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

valgrind --tool=dhat reports these as heap allocations that only have a
lifetime of a few hundred instructions, or even less than 100.
@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #6055 (f287288) into develop (ff5902e) will increase coverage by 0.03%.
The diff coverage is 91.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6055      +/-   ##
===========================================
+ Coverage    74.25%   74.29%   +0.03%     
===========================================
  Files         1444     1444              
  Lines       157460   157444      -16     
===========================================
+ Hits        116928   116969      +41     
+ Misses       40532    40475      -57     
Impacted Files Coverage Δ
src/goto-instrument/code_contracts.h 94.11% <ø> (ø)
src/solvers/flattening/boolbv_case.cpp 0.00% <0.00%> (ø)
src/solvers/flattening/boolbv_cond.cpp 0.00% <0.00%> (ø)
src/solvers/prop/prop.cpp 42.85% <0.00%> (-42.86%) ⬇️
src/solvers/prop/prop.h 84.37% <ø> (ø)
src/solvers/sat/cnf.h 83.33% <ø> (ø)
src/util/ssa_expr.h 100.00% <ø> (ø)
src/solvers/flattening/boolbv.cpp 79.81% <50.00%> (+0.29%) ⬆️
src/goto-instrument/code_contracts.cpp 84.75% <100.00%> (+0.46%) ⬆️
src/goto-symex/field_sensitivity.cpp 90.90% <100.00%> (-0.06%) ⬇️
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a7b064...f287288. Read the comment docs.

@kroening kroening merged commit 85728e0 into diffblue:develop Apr 29, 2021
@tautschnig tautschnig deleted the short-lived branch April 29, 2021 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants