Skip to content

Conversation

tautschnig
Copy link
Collaborator

We do not seem to generate such an expression in the code base, and the
current implementation is rather dubious for it returns the multiple of
8 bits in the propositional encoding.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

We do not seem to generate such an expression in the code base, and the
current implementation is rather dubious for it returns the multiple of
8 bits in the propositional encoding.
@codecov
Copy link

codecov bot commented Apr 3, 2021

Codecov Report

Merging #6008 (ffd00f0) into develop (9ae905b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6008   +/-   ##
========================================
  Coverage    74.22%   74.23%           
========================================
  Files         1444     1444           
  Lines       157328   157309   -19     
========================================
- Hits        116783   116781    -2     
+ Misses       40545    40528   -17     
Impacted Files Coverage Δ
src/goto-instrument/code_contracts.h 94.11% <ø> (ø)
src/solvers/flattening/boolbv.cpp 79.27% <ø> (+2.46%) ⬆️
src/solvers/smt2/smt2_conv.cpp 60.07% <ø> (+0.12%) ⬆️
src/goto-instrument/code_contracts.cpp 83.93% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e88f92...ffd00f0. Read the comment docs.

@tautschnig tautschnig merged commit 366989f into diffblue:develop Apr 3, 2021
@tautschnig tautschnig deleted the no-width branch April 3, 2021 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants