C front-end: labelled declarations are only supported by Visual Studio #5931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
chrisr-diffblue,
kroening and
peterschrammel
as code owners
tautschnig
force-pushed
the
labelled-decls
branch
2 times, most recently
from
75f7615 to
99822bc
Compare
Codecov ReportBase: 78.39% // Head: 78.40% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #5931 +/- ##
========================================
Coverage 78.39% 78.40%
========================================
Files 1655 1655
Lines 190281 190302 +21
========================================
+ Hits 149172 149200 +28
+ Misses 41109 41102 -7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tautschnig
force-pushed
the
labelled-decls
branch
from
99822bc to
42dad02
Compare
tautschnig
force-pushed
the
labelled-decls
branch
from
d14facc to
06e9742
Compare
tautschnig
force-pushed
the
labelled-decls
branch
from
06e9742 to
8201ead
Compare
tautschnig
force-pushed
the
labelled-decls
branch
from
8201ead to
8cef4ab
Compare
tautschnig
force-pushed
the
labelled-decls
branch
from
8cef4ab to
8e41e24
Compare
tautschnig
force-pushed
the
labelled-decls
branch
from
8e41e24 to
5ed44db
Compare
|
The link https://github.com/gcc-mirror/gcc/blob/master/gcc/c/c-parser.c#L5553 doesn't work. |
tautschnig
force-pushed
the
labelled-decls
branch
from
5ed44db to
37b4773
Compare
I have updated the link in both the commit message and the PR description. |
In order to support GCC's label attributes even when the semicolon is omitted, distinguish GCC and Visual Studio modes when parsing labelled statements. See https://github.com/gcc-mirror/gcc/blob/master/gcc/c/c-parser.cc#L6070 for GCC's limitation, which we now mimic. (We already supported attributes followed by a semicolon, which GCC's documentation mandates, but the Linux kernel doesn't always follow this rule.) Fixed regression tests that had declarations immediately following a label.
Also added braces where an if condition spans multiple lines, and replace one case of if(...) return true; return false; by return (...);
tautschnig
force-pushed
the
labelled-decls
branch
from
37b4773 to
a5f789a
Compare
peterschrammel
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support GCC's label attributes even when the semicolon is
omitted, distinguish GCC and Visual Studio modes when parsing labelled
statements. See
https://github.com/gcc-mirror/gcc/blob/master/gcc/c/c-parser.cc#L6070 for
GCC's limitation, which we now mimic. (We already supported attributes
followed by a semicolon, which GCC's documentation mandates, but the
Linux kernel doesn't always follow this rule.) Fixed regression tests
that had declarations immediately following a label.