Skip to content

bv_pointerst: encapsulate offset/object bit layout #5832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

tautschnig
Copy link
Collaborator

@tautschnig tautschnig commented Feb 16, 2021

Hide erase/resize operations behind a proper interface.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Feb 16, 2021

Codecov Report

Merging #5832 (ad7584b) into develop (81ecf05) will increase coverage by 0.01%.
The diff coverage is 82.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5832      +/-   ##
===========================================
+ Coverage    72.84%   72.86%   +0.01%     
===========================================
  Files         1421     1421              
  Lines       154138   154173      +35     
===========================================
+ Hits        112289   112337      +48     
+ Misses       41849    41836      -13     
Impacted Files Coverage Δ
src/goto-programs/goto_convert_class.h 87.30% <ø> (ø)
src/solvers/flattening/boolbv_union.cpp 57.14% <0.00%> (ø)
src/solvers/flattening/boolbv_with.cpp 65.30% <0.00%> (ø)
src/solvers/flattening/boolbv.h 69.56% <50.00%> (ø)
src/solvers/flattening/bv_pointers.cpp 81.18% <77.07%> (+0.28%) ⬆️
src/goto-programs/builtin_functions.cpp 54.57% <94.11%> (+1.03%) ⬆️
src/ansi-c/c_typecheck_expr.cpp 74.42% <100.00%> (+0.40%) ⬆️
src/solvers/flattening/boolbv_byte_extract.cpp 70.00% <100.00%> (ø)
src/solvers/flattening/boolbv_byte_update.cpp 100.00% <100.00%> (ø)
src/solvers/flattening/boolbv_width.cpp 76.69% <100.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eeb48a2...ad7584b. Read the comment docs.

Copy link
Collaborator

@martin-cs martin-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tidying this up.

@@ -104,6 +104,34 @@ class bv_pointerst:public boolbvt
postponed_listt postponed_list;

void do_postponed(const postponedt &postponed);

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are making changes to this PR some documentation here might be nice.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I arguably should have done this right away. Now fixed.

@tautschnig tautschnig self-assigned this Feb 17, 2021
Hide erase/resize operations behind a proper interface.
@tautschnig tautschnig merged commit 9288864 into diffblue:develop Feb 18, 2021
@tautschnig tautschnig deleted the bv_pointers-api branch February 18, 2021 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants