Skip to content

Do not rely on Clang's results to verify our GCC version handling #5829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2021

Conversation

tautschnig
Copy link
Collaborator

We use __float128 to distinguish GCC versions, which is not a
distinguishing factor for Clang. (It's supported on several Clang
versions on x86, but not on Apple's M1/ARM.) This commit effectively
disables the gcc_version1 test on macOS (where "gcc" really is Clang).

Fixes: #5828

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

We use __float128 to distinguish GCC versions, which is not a
distinguishing factor for Clang. (It's supported on several Clang
versions on x86, but not on Apple's M1/ARM.) This commit effectively
disables the gcc_version1 test on macOS (where "gcc" really is Clang).

Fixes: diffblue#5828
Copy link
Contributor

@NlightNFotis NlightNFotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on the M1 platform, and the tests are now passing. Thanks 👍🏻

@codecov
Copy link

codecov bot commented Feb 16, 2021

Codecov Report

Merging #5829 (09251eb) into develop (9778868) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5829   +/-   ##
========================================
  Coverage    72.85%   72.85%           
========================================
  Files         1423     1423           
  Lines       154072   154072           
========================================
  Hits        112244   112244           
  Misses       41828    41828           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c408367...09251eb. Read the comment docs.

@tautschnig tautschnig self-assigned this Feb 16, 2021
@tautschnig tautschnig merged commit 8370c47 into diffblue:develop Feb 16, 2021
@tautschnig tautschnig deleted the fix-5828 branch February 16, 2021 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing tests on M1-Arm64 on develop
2 participants