Store pointer encoding configuration in boolbv_widtht #5822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
kroening,
martin-cs and
peterschrammel
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #5822 +/- ##
========================================
Coverage 72.85% 72.85%
========================================
Files 1423 1421 -2
Lines 154072 154130 +58
========================================
+ Hits 112244 112292 +48
- Misses 41828 41838 +10
Continue to review full report at Codecov.
|
martin-cs
approved these changes
Feb 14, 2021
tautschnig
force-pushed
the
pointer-encoding-width
branch
from
e94bdbb to
cb5bef5
Compare
The special-casing of the endianness encoding handled by bv_endianness_mapt is really specific to bv_pointerst, not boolbvt in general. Thus, move this data structure to bv_pointers.cpp and enable overriding the endianness map from boolbvt. This commit is refactoring only, no changes in behaviour intended.
With upcoming changes to pointer encoding it will be necessary to enable children of boolbvt to define their own bit encoding width of data types. This commit is refactoring only, no changes in behaviour intended.
In preparation of tweaking the propositional encoding, place all knowledge of the bit width of encoded pointers in bv_pointerst. Also, do not hard-code the width just once, but really look at each type.
tautschnig
force-pushed
the
pointer-encoding-width
branch
from
cb5bef5 to
5cf2b07
Compare
tautschnig
requested review from
chrisr-diffblue,
hannes-steffenhagen-diffblue and
smowton
as code owners
kroening
approved these changes
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than handling the object/offset bit width in multiple places,
make boolbv_widtht the only place to provide this information.