goto-instrument --model-argc-argv: Explicitly initialise argc, argv #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
force-pushed
the
model-argc-argv
branch
from
80f9e9b to
0d933a0
Compare
tautschnig
force-pushed
the
model-argc-argv
branch
from
0d933a0 to
79b2e16
Compare
tautschnig
force-pushed
the
model-argc-argv
branch
3 times, most recently
from
eaf7ed1 to
87e6aed
Compare
tautschnig
force-pushed
the
model-argc-argv
branch
from
87e6aed to
7ae0e17
Compare
tautschnig
force-pushed
the
model-argc-argv
branch
from
7ae0e17 to
12b28e2
Compare
There was a problem hiding this comment.
Isn't this C-specific and should therefore go into ansi-c/ ?
A language-independent version would be appreciate so that it works also for Java.
There was a problem hiding this comment.
It currently indeed is C specific, and the updated version includes an explicit check for mode==ID_C. I would, however, appreciate any work for supporting Java.
There was a problem hiding this comment.
What happens to the global variable initializations?
|
I think this looks good and just needs a rebase. |
Warn when --model-argc-argv is used for main functions without arguments
tautschnig
force-pushed
the
model-argc-argv
branch
from
12b28e2 to
ed92d87
Compare
|
I have addressed all comments, rebased, and added a regression test. That test, however, is only truly meaningful once #453 is merged. |
Closed
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Programs using argc and argv need to have these set up properly. This patch introduces an instrumentation achieving this.