Skip to content

Fix depth_iterator_baset move assignment to return a value. #5312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2020
Merged

Fix depth_iterator_baset move assignment to return a value. #5312

merged 1 commit into from
Apr 22, 2020

Conversation

markrtuttle
Copy link
Collaborator

Make the depth_iterator_baset assignment operator return a value.

The type says it should return a value, and VS2019 fails to builds without a return value.

smowton
smowton approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@smowton smowton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty amazed this ever compiled anywhere!

@markrtuttle markrtuttle mentioned this pull request Apr 21, 2020
Closed
@tautschnig tautschnig merged commit 7c6fb9c into diffblue:develop Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smowton smowton smowton approved these changes

@kroening kroening Awaiting requested review from kroening kroening is a code owner

@peterschrammel peterschrammel Awaiting requested review from peterschrammel peterschrammel is a code owner

@pkesseli pkesseli Awaiting requested review from pkesseli

@tautschnig tautschnig Awaiting requested review from tautschnig tautschnig is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markrtuttle @smowton @tautschnig