Skip to content

Conversation

tautschnig
Copy link
Collaborator

Depending on the exact order of building directories, Makefile-based
builds of symtab2gb would sometimes fail as json.a had not been built
(and no rule for building it was present).

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Depending on the exact order of building directories, Makefile-based
builds of symtab2gb would sometimes fail as json.a had not been built
(and no rule for building it was present).
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 4ca7c9b).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/126418525


symtab2gb.dir: util.dir goto-programs.dir json-symtab-language.dir
symtab2gb.dir: util.dir goto-programs.dir langapi.dir linking.dir \
json.dir json-symtab-language.dir
Copy link
Contributor

@hannes-steffenhagen-diffblue hannes-steffenhagen-diffblue Sep 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a bit sketchy. json-symtab-language.dir should already depend on langapi.dir and json.dir right? And linking.dir should already be included in goto-programs.dir?

If not, then I think those should be fixed to include these.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, there isn't really that kind of dependency: it is perfectly safe to build, e.g., json-symtab-language, just the linking will fail. And that's really the only dependencies that are expressed here.

@codecov-io
Copy link

Codecov Report

Merging #5102 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5102   +/-   ##
========================================
  Coverage    69.69%   69.69%           
========================================
  Files         1321     1321           
  Lines       109346   109346           
========================================
  Hits         76205    76205           
  Misses       33141    33141

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b4de42...4ca7c9b. Read the comment docs.

@tautschnig tautschnig merged commit fab409d into diffblue:develop Sep 10, 2019
@tautschnig tautschnig deleted the fix-symbtab2gb-build branch September 10, 2019 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants