Skip to content

Correct return value test of to_integer #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2017
Merged

Correct return value test of to_integer #508

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/java_bytecode/expr2java.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ std::string expr2javat::convert_constant(
dest.reserve(char_representation_length);

mp_integer int_value;
if(!to_integer(src, int_value))
if(to_integer(src, int_value))
assert(false);

dest+="(char)'";
Expand All @@ -238,7 +238,7 @@ std::string expr2javat::convert_constant(
{
// No byte-literals in Java, so just cast:
mp_integer int_value;
if(!to_integer(src, int_value))
if(to_integer(src, int_value))
assert(false);
std::string dest="(byte)";
dest+=integer2string(int_value);
Expand All @@ -248,7 +248,7 @@ std::string expr2javat::convert_constant(
{
// No short-literals in Java, so just cast:
mp_integer int_value;
if(!to_integer(src, int_value))
if(to_integer(src, int_value))
assert(false);
std::string dest="(short)";
dest+=integer2string(int_value);
Expand All @@ -258,7 +258,8 @@ std::string expr2javat::convert_constant(
{
// long integer literals must have 'L' at the end
mp_integer int_value;
to_integer(src, int_value);
if(to_integer(src, int_value))
assert(false);
std::string dest=integer2string(int_value);
dest+='L';
return dest;
Expand Down