Skip to content

Conversation

kroening
Copy link
Member

@kroening kroening commented Jun 1, 2019

This re-enables compilation with clang.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we not notice a failure in CI?!

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 17384f7).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/113973817

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (develop@a2a5672). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #4743   +/-   ##
==========================================
  Coverage           ?   68.46%           
==========================================
  Files              ?     1270           
  Lines              ?   104774           
  Branches           ?        0           
==========================================
  Hits               ?    71737           
  Misses             ?    33037           
  Partials           ?        0
Impacted Files Coverage Δ
src/statement-list/statement_list_parse_tree.h 91.3% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2a5672...17384f7. Read the comment docs.

@kroening kroening merged commit 022c79e into develop Jun 1, 2019
@kroening kroening deleted the statement-list-destructor branch June 1, 2019 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants