direct support for ID_c_bool in exprt #438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `is_true()` / `is_false()` functions in `exprt` currently support only the `ID_bool` type. In Java, Boolean values are represented as `ID_c_bool` due to the internal JVM usage of integers. Adding this support here seems easier than having special treatment in `java_bytecode`.
peterschrammel
approved these changes
Jan 16, 2017
|
bool is very different from c_bool, and any confusion between the two should be avoided. In general, there shouldn't be anything language-specific in util/*. |
NathanJPhillips
pushed a commit
to NathanJPhillips/cbmc
that referenced
this pull request
Aug 22, 2018
Add GPG keys to improve Travis build stability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
is_true()/is_false()functions inexprtcurrently supportonly the
ID_booltype. In Java, Boolean values are represented asID_c_booldue to the internal JVM usage of integers. Adding thissupport here seems easier than having special treatment in
java_bytecode.cf. #221