Skip to content

Document ait; first stab at concurrency_aware_ait. #4093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2019
Merged

Document ait; first stab at concurrency_aware_ait. #4093

merged 1 commit into from
Feb 6, 2019

Conversation

johanneskloos
Copy link
Member

ait, ait_baset and related classes all have documentation now.

The full documentation of concurrency_aware_ait needs input from
someone who really understands the algorithm.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@peterschrammel peterschrammel changed the title [Documentation] Document ait; first stab at concurrency_aware_ait. Document ait; first stab at concurrency_aware_ait. Feb 5, 2019
Copy link
Contributor

@owen-mc-diffblue owen-mc-diffblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clear

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 0f7f11d).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/99821693

@owen-mc-diffblue
Copy link
Contributor

@johanneskloos I think you may have force-pushed the wrong branch - none of the updates have been made in what I can see

The full documentation of concurrency_aware_ait needs input from
someone who really understands the algorithm.

For the <!-- --> trick above, see
https://stackoverflow.com/questions/46744573/.
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫
This PR failed Diffblue compatibility checks (cbmc commit: 74b9e45).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/99921983
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: f6b24fb).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/99925470

@tautschnig tautschnig merged commit 8518ed5 into diffblue:develop Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants