Replace uses of deprecated index_exprt constructors #3765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tautschnig
commented
Jan 11, 2019
tautschnig
commented
- Each commit message has a non-empty body, explaining why the change was made.
- n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
- Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- n/a My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.
tautschnig
requested review from
kroening,
martin-cs,
peterschrammel,
pkesseli and
smowton
as code owners
tautschnig
force-pushed
the
index-expr-constructor
branch
from
4a27ea0 to
5af02b3
Compare
|
I would probably hold the second commit for a bit longer. The commit that deprecated that constructor is from Sep 21 2018, and I would give it perhaps a minimum of 6 months. |
kroening
approved these changes
Jan 11, 2019
tautschnig
changed the title
tautschnig
force-pushed
the
index-expr-constructor
branch
from
5af02b3 to
fcf93d7
Compare
|
@kroening Done, this PR now just has the first commit. |
allredj
reviewed
Jan 11, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 5af02b3).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/97070479
allredj
reviewed
Jan 11, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: fcf93d7).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/97075928
This is one of the steps towards removing deprecated functions. In several cases it also isn't necessary to explicitly pass the type as it can be picked up from the first constructor argument.
tautschnig
force-pushed
the
index-expr-constructor
branch
from
fcf93d7 to
088b35f
Compare
allredj
reviewed
Jan 12, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 088b35f).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/97113006
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.