Initialization ordering #3729
Merged
Initialization ordering #3729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kroening
commented
Jan 8, 2019
kroening
commented
- Each commit message has a non-empty body, explaining why the change was made.
- Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
- Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- n/a My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.
|
The actual change is small; look at 2nd commit. |
Refactoring, reduces the size of a function
kroening
force-pushed
the
initialization-ordering
branch
from
5ac4ef7 to
d13f1da
Compare
allredj
reviewed
Jan 9, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: d13f1da).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/96722472
tautschnig
approved these changes
Jan 9, 2019
src/linking/static_lifetime_init.cpp
Outdated
| if(code.has_value()) | ||
| dest.add(std::move(*code)); | ||
| } | ||
| if(has_prefix(id2string(id), CPROVER_PREFIX)) |
There was a problem hiding this comment.
The use of id2string seems unnecessary, we are dealing with a std::string already.
This ensures, among others, that the rounding mode is set before any initializers are evaluated. Fixes #3708.
kroening
force-pushed
the
initialization-ordering
branch
from
d13f1da to
958a61f
Compare
allredj
reviewed
Jan 9, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 958a61f).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/96739026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.