Skip to content

Move flatten_byte_* to lowering [blocks: #2068, #2501] #3290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2018

Conversation

tautschnig
Copy link
Collaborator

The operations in this code are not tied to Boolean flattening and instead do rewrites that are usable within any back-end.

This is a first step towards getting #2068 in a shape that can be reviewed and merged. No functional changes in this PR.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

The operations in this code are not tied to Boolean flattening and instead do
rewrites that are usable within any back-end.
The file will be substantially rewritten in follow-up commits and there is no
need to do a large-scale whitespace change at this point.
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫
This PR failed Diffblue compatibility checks (cbmc commit: 57f8848).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/90582269
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

class namespacet;
class popcount_exprt;

exprt flatten_byte_extract(const byte_extract_exprt &src, const namespacet &ns);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If flattening is different from lowering then why are the functions in lowering called flattening?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They will be renamed (I had already done so in 8cd566e), but I wanted to keep this one as easy as possible to review. I'll follow up with a PR doing the renaming shortly.

@tautschnig tautschnig changed the title Move flatten_byte_* to lowering [blocks: #2068] Move flatten_byte_* to lowering [blocks: #2068, #2501] Nov 7, 2018
@kroening kroening merged commit e44a9ab into diffblue:develop Nov 7, 2018
@tautschnig tautschnig deleted the move-flatten-byte-ops branch November 7, 2018 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants