Skip to content

Conversation

@kroening
Copy link
Collaborator

@kroening kroening commented Nov 4, 2018

This is a substantial change in the console interface: cbmc now gives the line number of the property in the summary result view.

Previously, the only way to obtain this information was to use --show-properties.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link
Contributor

@smowton smowton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though CI failure looks real

@kroening kroening force-pushed the results-line-number branch from 5cb389b to 98beb18 Compare November 5, 2018 10:28
@kroening kroening force-pushed the results-line-number branch from 98beb18 to 73c3384 Compare November 5, 2018 12:36
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 73c3384).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/90265840

@tautschnig tautschnig merged commit 3346cf6 into develop Nov 5, 2018
@tautschnig tautschnig deleted the results-line-number branch November 5, 2018 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants