Console colors #3015

kroening · 2018-09-21T16:18:49Z

Each commit message has a non-empty body, explaining why the change was made.
My contribution is formatted in line with CODING_STANDARD.md.
Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
My commit message includes data points confirming performance improvements (if claimed).
My PR is restricted to a single feature or bugfix.
White-space or formatting changes outside the feature-related changed lines are in commits of their own.

kroening · 2018-09-21T16:19:15Z

This will be hard to test: The effect is only visible when output is not redirected.

tautschnig

Essentially items 3 and 7 of the PR checklist. Please don't assign others when those cannot (yet) be ticked as it really means that the focus when reviewing shifts from the meat of the work to those superficial bits.

tautschnig · 2018-09-21T16:24:46Z

src/util/cout_message.cpp

+#endif
+}
+
+std::string console_message_handlert::command(unsigned c) const


Missing documentation. The name does not in an obvious way relate to it's functionality, and what values c should take is a mystery.

tautschnig · 2018-09-21T16:26:16Z

src/util/cout_message.h

 protected:
  const bool always_flush;
+  bool is_a_tty;
+  bool use_SGR;


tautschnig · 2018-09-21T16:26:52Z

src/util/message.h

    return m;
  }

+  std::string command(unsigned c) const


tautschnig · 2018-09-21T16:27:52Z

src/util/message.h

+      return std::string();
+  }
+
+  // return to default


What is the "default"? Default of what? Also: not Doxygen.

tautschnig · 2018-09-21T16:28:10Z

src/util/message.h

+    return command(0);
+  }
+
+  // set red foreground color


Doxygen, please.

tautschnig · 2018-09-21T16:30:21Z

src/util/ui_message.cpp

-                                                : uit::PLAIN,
+      cmdline.isset("xml-ui")
+        ? uit::XML_UI
+        : cmdline.isset("json-ui") ? uit::JSON_UI : uit::PLAIN,


Also spurious clang-format change.

tautschnig · 2018-09-21T16:30:37Z

src/util/ui_message.cpp

+                                     : cmdline.get_value("timestamp") == "wall"
+                                         ? timestampert::clockt::WALL_CLOCK
+                                         : timestampert::clockt::NONE
+                                 : timestampert::clockt::NONE)


clang-format has had fun. Manually reverted.

allredj

Passed Diffblue compatibility checks (cbmc commit: 2c09f3b).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/85603358

allredj

Passed Diffblue compatibility checks (cbmc commit: 8a40b36).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/85897347

tautschnig · 2018-09-25T18:20:19Z

src/util/message.h

  }

-  /// return to default formatting
+  /// return to default formatting, as defined by clienta


"clienta" is probably a typo, but I wouldn't understand what the "client" is either.
Nit-pick: Change is in the wrong commit (should just be part of the original commit introducing the documentation).

This enables colorful formatting of any message printed through the messaget API. Server-side implementation is provided for Windows and Unix consoles.

Failed properties are red, passing ones are green, and the overall result is in bold.

This mimicks what newer versions of gcc do.

the summary result is now bold

allredj

Passed Diffblue compatibility checks (cbmc commit: d999a3e).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/85985276

kroening added enhancement work in progress labels Sep 21, 2018

kroening assigned tautschnig and peterschrammel Sep 21, 2018

kroening requested review from peterschrammel and tautschnig September 21, 2018 16:18

kroening requested review from pkesseli and smowton as code owners September 21, 2018 16:18

kroening force-pushed the console-colors branch 2 times, most recently from 652589b to 0033340 Compare September 21, 2018 16:20

tautschnig requested changes Sep 21, 2018

View reviewed changes

tautschnig assigned kroening and unassigned tautschnig and peterschrammel Sep 21, 2018

kroening force-pushed the console-colors branch 3 times, most recently from 580f708 to b370920 Compare September 21, 2018 18:45

kroening requested review from chrisr-diffblue and martin-cs as code owners September 21, 2018 18:49

kroening force-pushed the console-colors branch from d0f7727 to 2c09f3b Compare September 21, 2018 18:51

allredj reviewed Sep 21, 2018

View reviewed changes

ui_message_handlert retains console_message_handlert object

f06b563

kroening force-pushed the console-colors branch from 2c09f3b to 8a40b36 Compare September 25, 2018 15:13

kroening assigned tautschnig and unassigned kroening Sep 25, 2018

allredj reviewed Sep 25, 2018

View reviewed changes

tautschnig reviewed Sep 25, 2018

View reviewed changes

tautschnig approved these changes Sep 25, 2018

View reviewed changes

tautschnig removed their assignment Sep 25, 2018

tautschnig assigned kroening, peterschrammel, martin-cs and chrisr-diffblue Sep 25, 2018

kroening added 4 commits September 26, 2018 10:00

added a message color API

33569fa

This enables colorful formatting of any message printed through the messaget API. Server-side implementation is provided for Windows and Unix consoles.

use colors in BMC status reporting

f133a25

Failed properties are red, passing ones are green, and the overall result is in bold.

use colors in gcc personality

b27c1e8

This mimicks what newer versions of gcc do.

use formatting in goto-analyzer

d999a3e

the summary result is now bold

kroening force-pushed the console-colors branch from 8a40b36 to d999a3e Compare September 26, 2018 09:10

kroening removed the work in progress label Sep 26, 2018

kroening assigned peterschrammel and chrisr-diffblue and unassigned kroening, peterschrammel, martin-cs and chrisr-diffblue Sep 26, 2018

allredj reviewed Sep 26, 2018

View reviewed changes

peterschrammel approved these changes Sep 27, 2018

View reviewed changes

peterschrammel assigned chrisr-diffblue and unassigned chrisr-diffblue and peterschrammel Sep 27, 2018

tautschnig merged commit 9bd3c93 into develop Sep 27, 2018

tautschnig deleted the console-colors branch September 27, 2018 21:55

Console colors #3015

Console colors #3015

Uh oh!

Conversation

kroening commented Sep 21, 2018 • edited by tautschnig Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kroening commented Sep 21, 2018

Uh oh!

tautschnig left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

allredj left a comment

Choose a reason for hiding this comment

Uh oh!

allredj left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

allredj left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

kroening commented Sep 21, 2018 •

edited by tautschnig

Loading